Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: replace use mod::submod::{self} with use mod::submod #5991

Closed
alex opened this issue Dec 26, 2023 · 1 comment
Closed

Request: replace use mod::submod::{self} with use mod::submod #5991

alex opened this issue Dec 26, 2023 · 1 comment

Comments

@alex
Copy link
Member

alex commented Dec 26, 2023

Sometimes, in the course of a refactoring one starts with use mod::submod::{a, b, c, self} and then you end up with only {self}.

I think in effectively 100% of cases it's desirable to remove the ::{self}.

I do not believe the existing options for import formatting do this.

@alex
Copy link
Member Author

alex commented Dec 26, 2023

Nope, turns out rustfmt used to do this but it's not 100% semantically equivalent: #3568

Sorry about the noise!

@alex alex closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant