Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbot should recover better from parsing errors #1777

Open
asquared31415 opened this issue Feb 26, 2024 · 1 comment
Open

rustbot should recover better from parsing errors #1777

asquared31415 opened this issue Feb 26, 2024 · 1 comment
Labels
A-command-parsing Area: command parsing

Comments

@asquared31415
Copy link

rustbot seems to be very particular about its parsing, and if anything fails, the whole command fails.

here @rustbot label -needs-triage +A-diagnostics +D-papercut + D-incorrect I attempted to relabel some things, but accidentally had a space between a + and the label name, and rustbot completely failed to apply any of the label changes. It would have been nice if it at least applied the labels that parsed correctly.

and here @rustbot claim I'll work on fixing the suggestion at least, and possibly see about clarifying the diagnostic I attempted to assign myself after some (short) thinking, but I didn't realize that @rustbot claim must not have anything after it. It would be nice if rustbot just ignored things after the expected end of command, assuming them to be extra comments.

@Mark-Simulacrum
Copy link
Member

The goal of the current behavior is to make it less likely that a change in how we parse things (e.g., adding a new parameter) causes an existing command to parse differently.

@ehuss ehuss added the A-command-parsing Area: command parsing label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command-parsing Area: command parsing
Projects
None yet
Development

No branches or pull requests

3 participants