Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stride copying in generalize a bit #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluss
Copy link
Member

@bluss bluss commented May 17, 2021

While still not perfect - that should be solved in upstream ndarray, the
new version is an improvement since it checks the compatibility before
attempting to construct the array.

.into_raw_vec() is very hard to use correctly (this is inherent, it's
an access to the raw memory model), so the new version will actually
fail to convert in some cases that were passing as silent errors before
(related to internally sliced arrays, rather uncommon).

While still not perfect - that should be solved in upstream ndarray, the
new version is an improvement since it checks the compatibility before
attempting to construct the array.

`.into_raw_vec()` is very hard to use correctly (this is inherent, it's
an access to the raw memory model), so the new version will actually
fail to convert in some cases that were passing as silent errors before
(related to internally sliced arrays, rather uncommon).
@bluss bluss force-pushed the bluss/improve-generalize branch from 831dda2 to 831ecbe Compare May 17, 2021 19:28
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #288 (831ecbe) into master (a561e5a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   89.01%   89.04%   +0.03%     
==========================================
  Files          71       71              
  Lines        3577     3579       +2     
==========================================
+ Hits         3184     3187       +3     
+ Misses        393      392       -1     
Impacted Files Coverage Δ
ndarray-linalg/src/convert.rs 97.91% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a561e5a...831ecbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant