Correct Ratio::is_negative and Ratio::is_positive #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, good catch! Looks right -- I just want to hold this for a bit so #164 isn't disrupted... |
6 tasks
|
☔ The latest upstream changes (presumably #164) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. |
|
Just noticed, is there a reason you used bitwise |
Zero is not positive or negative. This was broken in 8be7e7b.
|
I've no idea, I've changed it to |
homu
added a commit
that referenced
this pull request
Apr 13, 2016
Correct Ratio::is_negative and Ratio::is_positive Zero is not positive or negative. This was broken in 8be7e7b.
|
⚡ Test exempted - status |
remexre
pushed a commit
to remexre/num
that referenced
this pull request
Jun 1, 2017
doc: follow Rust idiom of trailing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero is not positive or negative.
This was broken in 8be7e7b.