Revert "vsock: Skip tests causing CI failure" #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added a commit
to roypat/rust-vmm-ci
that referenced
this pull request
Sep 26, 2024
The code coverage tests already run in a privileged container, so this does not affect our security posture. Additionally, it will unblock vsock unit tests in the vhost-user-vsock crate, see also rust-vmm/vhost-device#706 and rust-vmm/vhost-device#728 Signed-off-by: Patrick Roy <[email protected]>
4 tasks
roypat
added a commit
to rust-vmm/rust-vmm-ci
that referenced
this pull request
Oct 10, 2024
The code coverage tests already run in a privileged container, so this does not affect our security posture. Additionally, it will unblock vsock unit tests in the vhost-user-vsock crate, see also rust-vmm/vhost-device#706 and rust-vmm/vhost-device#728 Signed-off-by: Patrick Roy <[email protected]>
stefano-garzarella
force-pushed
the
vsock-enable-af-vsock-tests
branch
2 times, most recently
from
906efa3
to
9d06de5
Compare
rust-vmm/rust-vmm-ci#165 allows us to run unittests in a privileged container, so we can use AF_VSOCK in our CI which was otherwise not allowed by docker. This was already enabled for coverage tests. Signed-off-by: Stefano Garzarella <[email protected]>
This reverts commit cec57c9. Now our CI is able to use AF_VSOCK, so let's force the tests to run to discover any problems in the future. Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
force-pushed
the
vsock-enable-af-vsock-tests
branch
from
9d06de5
to
dcd9d47
Compare
stefano-garzarella
requested review from
stsquad,
vireshk and
epilys
as code owners
vireshk
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cec57c9.
Thanks to rust-vmm/rust-vmm-ci#165 our CI is now able to use AF_VSOCK, so let's force the tests to run to discover any problems in the future.
Thanks to @roypat for the help on debugging and finding the solution :-)