Make wayland-sys dependency optional #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures are probably not this PR's fault. |
I figured as such. There seem to be a problem with the msrv and some doctests are failing because of this lint: https://rust-lang.github.io/rust-clippy/master/index.html#/needless_doctest_main Nothing seems actually related to the pr |
|
Please rebase on master for the CI fixes |
morr0ne
force-pushed
the
optional-wayland-sys
branch
from
6260f90
to
b74456d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this pr makes the wayland-sys dependency optional and only enables when the wayland feature is enabled.
I noticed that I was pulling in the wayland-sys dependency while only using only the drm backend.
I am not sure whether or not this was intended behavior but I would assume there is no reason to pull a wayland dependency when not using wayland