Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustler_precompiled to v0.5.2 #72

Conversation

Benjamin-Philip
Copy link
Contributor

Rustler Precompiled had a bug in v0.5.1 wherein precompiled NIFs could not run on Fedora and RHEL machines. See
philss/rustler_precompiled#30

This commit bumps Rustler Precompiled to v0.5.2 to eliminate this bug in html5erver.

Rustler Precompiled had a bug in v0.5.1 wherein precompiled NIFs
could not run on Fedora and RHEL machines. See
philss/rustler_precompiled#30

This commit bumps Rustler Precompiled to v0.5.2 to eliminate this bug in
html5erver.
@philss
Copy link
Member

philss commented Oct 4, 2022

@Benjamin-Philip thanks again! Since the version requirement is relaxed, you can upgrade rustler_precompiled in projects using html5ever_elixir by running mix deps.update rustler_precompiled.

In any case, this change is going to force the upgrade, so it's good.

@philss philss merged commit b73fec0 into rusterlium:master Oct 4, 2022
@Benjamin-Philip
Copy link
Contributor Author

In that case I'm gonna send a PR to Floki as well.

@Benjamin-Philip Benjamin-Philip deleted the bp-bump-rustler-precompiled-to-5.2.0 branch October 4, 2022 03:54
@Benjamin-Philip
Copy link
Contributor Author

Benjamin-Philip commented Oct 4, 2022

Could you release a new patched version (v0.13.2) as well?

@philss
Copy link
Member

philss commented Oct 4, 2022

Could you release a new patched version (v0.13.2) as well?

@Benjamin-Philip sure! But I'm going to do that in the morning. Sleep time for me now 😄

@Benjamin-Philip
Copy link
Contributor Author

Sure! It's 9:30 am for me.

@Benjamin-Philip
Copy link
Contributor Author

Benjamin-Philip commented Oct 4, 2022

@philss, I don't mean to be rude, but ping.

@philss
Copy link
Member

philss commented Oct 4, 2022

@Benjamin-Philip no problem. This is released in v0.14.0.

@philss
Copy link
Member

philss commented Oct 4, 2022

Could you release a new patched version (v0.13.2) as well?

I forgot to say that this would be a minor, since it would break who were depending of 0.4 of rustler_precompiled for some reason.

Benjamin-Philip added a commit to Benjamin-Philip/floki that referenced this pull request Oct 4, 2022
philss pushed a commit to philss/floki that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants