v1.7.0 prep, SubjectPublicKeyInfo -> SubjectPublicKeyInfoDer #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be 1.7 because downgrades will fail. |
Ah, good point. Will adjust (minus the branch name). |
cpu
changed the title
|
My bad for not catching this naming convention in #47! |
|
No worries, we missed it in review too! |
djc
approved these changes
May 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #47. @djc correctly noted we should have called this
SubjectPublicKeyInfoDerto match the other type names.This branch prepares 1.7.0 by renaming
SubjectPublicKeyInfotoSubjectPublicKeyInfoDer, and adding a deprecated type alias forSubjectPublicKeyInfoto maintain semver.Proposed release notes
SubjectPublicKeyInfowas renamed toSubjectPublicKeyInfoDer, and a deprecated type alias under the old name was added.