Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
Cert
type (which mostly represents a certificate) also doubled as a linked list node via the (somewhat cryptically named)ee_or_ca
field. Instead, use a linked list node type (here calledPathNode
to evoke the somewhat well-known notion of path building) that contains theCert
.Cert
construction becomes a lot more obvious and simple because it is no longer obliged to deal with the linked list, and we can draw a clean distinction between types for dealing the with the linked list path and types that just need the certificate data from aCert
.After spending some time with the path-building code, I wanted to try and improve cohesion so tacked on a bunch of commits that try to colocate related code.