small nightly clippy fixes #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice we never examine the `untrusted::Input` field of
a `GeneralName::DirectoryName` variant. Nightly clippy is flagging this:
```
error: field `0` is never read
--> src/subject_name/verify.rs:256:19
|
256 | DirectoryName(untrusted::Input<'a>),
| ------------- ^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
256 | DirectoryName(()),
| ~~
```
This commit switches the `GeneralName::DirectoryName` to be a variant
without any fields to resolve this finding. If we expand support for
`DirectoryName`'s in the future we can revisit.
In practice we never examine the `untrusted::Input` field of a `DistributionPointName::NameRelativeToCrlIssuer` variant. Nightly clippy is flagging this: ``` error: field `0` is never read --> src/x509.rs:89:29 | 89 | NameRelativeToCrlIssuer(untrusted::Input<'a>), | ----------------------- ^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 89 | NameRelativeToCrlIssuer(()), | ~~ ``` This commit switches `DistributionPointName::NameRelativeToCrlIssuer` to be a variant without any fields to resolve this finding.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 97.16% 97.18% +0.02%
==========================================
Files 19 19
Lines 4303 4299 -4
==========================================
- Hits 4181 4178 -3
+ Misses 122 121 -1 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI started failing the nightly clippy task (example) ~yesterday from a couple enum variants where we never accessed the inner fields.
This branch fixes both findings by removing the unused
untrusted::Inputinner fields.