Add support for P-521 curve with SHA-256/SHA-384 digests #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jul 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 19 19
Lines 4237 4237
=======================================
Hits 4123 4123
Misses 114 114 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Jul 21, 2024
|
Used administrative override to squash during merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Address #267
Description of changes:
aws-lc-rs has added support for ECDSA P-521 with SHA1, SHA224, SHA256, SHA384 in aws/aws-lc-rs#461.
This PR introduces ECDSA_P521_SHA256 and ECDSA_P521_SHA384 for aws-lc-rs to webpki.