Add Haptic Feedback Support for Window Snapping #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll check it out it this weekend. |
rxhanson
reviewed
Apr 22, 2024
rxhanson
reviewed
Apr 22, 2024
rxhanson
reviewed
Apr 22, 2024
rxhanson
reviewed
Apr 22, 2024
|
Looks great! Just a couple of adjustments that I put in suggestions for:
|
Co-authored-by: Ryan Hanson <[email protected]>
Co-Authored-By: Ryan Hanson <[email protected]>
|
Excellent! I'm planning on pushing out a release this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to this project, so if there are any issues or suggestions, please don't hesitate to let me know.
In this pull request, I've implemented support for haptic feedback when moving a window onto a snap area. A simple setting that now I cannot live without :)