Add CascadeActiveAppWindows refinements #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the cascade goes to the quadrant in which the center of the active window is found - width and height of the cascaded windows are limited so that they remain within the screen
|
Example screenshot: 
|
|
Thanks for continuing to improve your work here! I understand the changes you're making, and this corner of the code is mainly only touched by you, but if you don't mind let's make the names of everything more readable. I'll comment inline. |
rxhanson
reviewed
Jul 28, 2024
| bottom = windowFrame.midY > screenFrame.midY | ||
| self.n = n | ||
| let m = CGSize(width: screenFrame.width - CGFloat(n - 1) * delta, height: screenFrame.height - CGFloat(n - 1) * delta) | ||
| self.size = CGSize(width: min(size.width, m.width), height: min(size.height, m.height)) |
There was a problem hiding this comment.
n and m here take some reasoning to figure out what they mean. Can you think of better names for them?
| filtered.removeFirst() | ||
| filtered.append(first) | ||
| firstSize = first.size | ||
| caaw = CascadeActiveAppWindows(windowFrame: first.frame, screenFrame: screenFrame, n: filtered.count, size: first.size!, delta: delta) |
There was a problem hiding this comment.
If CascadeActiveAppWindows becomes CascadeActiveAppParameters, then we could change caaw to something like cascadeParameters
|
@rxhanson Thank you for the suggestions to make the code more readable, which I now applied. |
|
Looks good! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes refinements to the command
cascadeActiveApp(published inrectangle v0.69from PR #1146 and #1163)before: the cascade goes to the top left quadrant
now: the cascade goes to the quadrant in which the center of the active window is found, so that the user can have up to 4 different apps cascaded
before: the size of the active (first) window is enforced onto the other windows in the cascade
now: same, but the size width and height are constrained so that all cascaded windows remain within the screen