Add tslib as runtime dep
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#370 (comment) According to [typescriptlang.org](https://www.typescriptlang.org/tsconfig#importHelpers), not using `importHelpers` "can result in code duplication if the same helper is used in many different modules". So use `tslib` might be a better solution. The reason the unit tests are not failing is that unit tests use the development environment's `node_modules` when running. Tested on my computer. close #370
|
@ilharp How were you able to confirm the fix on your computer? |
ryanluker
approved these changes
May 8, 2022
|
KK thanks! I thought that was the case so I confirmed locally your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#370 (comment)
According to typescriptlang.org, not using
importHelpers"can result in code duplication if the same helper is used in many different modules". So usetslibmight be a better solution.The reason the unit tests are not failing is that unit tests use the development environment's
node_moduleswhen running.Tested on my computer.
close #370