Prepatched fonts: Revive some ligature removal #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Some sourcefonts, even that are monospaced, have a `fi` and/or `fl` ligature that maps into one cell. That looks very strange. [how] Partially revert commit 148b0c4 Sunset ligature removal for the cases that have a one-cell `fi`, `fl`, etc ligature, or a `ldot` related ligature - that is active by default. Discretionary ligatures or Stylistic Sets are not changed. Do the removal on all patched fonts for consistency, not just `Nerd Font Mono`. [note] On Noto different subtables are needed for Sans, Serif and Sans-Mono. We can not set up different configs for each, so all are tried in all fonts and might fail (this is normal). Same holds for OpenDyslexic Alta, Regular, Mono, Bold... Fixes: #1187 Signed-off-by: Fini Jastrow <[email protected]>
|
This direct subtable removal is huddely muddely unclean 😒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Some sourcefonts, even that are monospaced, have a
fiand/orflligature that maps into one cell. That looks very strange.[how]
Partially revert commit
148b0c4 Sunset ligature removal
for the cases that have a one-cell
fi,fl, etc ligature, or aldotrelated ligature - that is active by default. Discretionary ligatures or Stylistic Sets are not changed.Do the removal on all patched fonts for consistency, not just
Nerd Font Mono.[note]
On Noto different subtables are needed for Sans, Serif and Sans-Mono. We can not set up different configs for each, so all are tried in all fonts and might fail (this is normal).
Fixes: #1187
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)