Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codicons: Preserve smaller icons #1216

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented May 8, 2023

[why]
The codicons have 3 obvious (from the name) pairs of regular and small icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: #1214

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii Finii added this to the v3.0.1 milestone May 8, 2023
@Finii Finii closed this May 9, 2023
@Finii Finii force-pushed the feature/codicons-scale-pairs branch from 738034c to 3445d2d Compare May 9, 2023 16:12
@Finii Finii deleted the feature/codicons-scale-pairs branch May 10, 2023 11:04
@Finii Finii mentioned this pull request May 10, 2023
3 tasks
@Finii
Copy link
Collaborator Author

Finii commented May 12, 2023

Why is this closed without commits?

[why]
The codicons have 3 obvious (from the name) pairs of regular and small
icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: #1214

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii restored the feature/codicons-scale-pairs branch May 12, 2023 13:22
@Finii Finii reopened this May 12, 2023
@Finii Finii merged commit 43b9ae1 into master May 12, 2023
@Finii Finii deleted the feature/codicons-scale-pairs branch May 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cod-debug-continue-small is not small
1 participant