Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font: 0xProto #1381

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Add font: 0xProto #1381

merged 3 commits into from
Nov 11, 2023

Conversation

piraces
Copy link
Contributor

@piraces piraces commented Oct 13, 2023

Description

Add new font 0xProto

Requirements / Checklist

What does this Pull Request (PR) do?

Adds the font 0xProto

How should this be manually tested?

N/A

Any background context you can provide?

I followed the entire contributing guide and tried to base this on other fonts added in successfully merged PRs.

What are the relevant tickets (if any)?

Closes #1379

Screenshots (if appropriate or helpful)

N/A

@piraces
Copy link
Contributor Author

piraces commented Oct 13, 2023

@all-contributors please add @piraces for code

@allcontributors
Copy link
Contributor

@piraces

I've put up a pull request to add @piraces! 🎉

@piraces
Copy link
Contributor Author

piraces commented Oct 13, 2023

Hi there! First time contributing to Nerd Fonts.
I followed the entire contributing guide and tried to base this on other fonts added in successfully merged PRs.

Please let me know if I have something wrong 🙏

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost good! :-)

Adding a new font is of course always also kind of 'political'.
Is the font interesting enough?
Is there demand?
Etc.
That is of course hard for newly created fonts.

bin/scripts/lib/fonts.json Outdated Show resolved Hide resolved
patched-fonts/0xProto/README.md Outdated Show resolved Hide resolved
@Finii
Copy link
Collaborator

Finii commented Oct 13, 2023

Forgot to write first of all:

Thank you for the PR :-)

@piraces
Copy link
Contributor Author

piraces commented Oct 14, 2023

Hi @Finii, first of all thank you for all the explication!
It´s awesome to contribute to a repo and have this kind of warm welcoming ☺️

I think I understood the process now. I have made the suggested changes in overwriting the same commit and "force pushing" (let me know if you are not ok with "force pushes").


Off-topic (kind of): thinking about the contributing.md, adding a new font guide section, I was thinking it may be useful to change it with this "new" steps (I can try to work on that too). Should we track this proposal in a new issue or discussion? Thanks! 👍

@Finii Finii added this to the v3.1.0 milestone Oct 14, 2023
bin/scripts/lib/fonts.json Outdated Show resolved Hide resolved
@Finii
Copy link
Collaborator

Finii commented Oct 14, 2023

I wrote something on adding fonts here:

image

and "force pushing" (let me know if you are not ok with "force pushes")

Force pushes are absolutely ok in PRs (and better than having 10 commits that fix fixes ;)

Off-topic (kind of): thinking about the contributing.md, adding a new font guide section, I was thinking it may be useful to change it with this "new" steps (I can try to work on that too). Should we track this proposal in a new issue or discussion?

Ah, that is rather old and I completely forgot that section.
I'm not so sure with add-a-font PR; in principle we would need to fix our repo setup first which we struggle since some years and there is no solution in sight. And adding a new font is - in contrast to when that paragraph had been added - rather trivial. Hmm.
The problem is that this repo grew exponentially with each added font, this is not sustainable.

I still have no solutions for the problems, and the repoRelease: false is just the first ministep in the right direction but not sufficient I fear.

What I wanted to say: I would rather not promote add-a-font PRs.
I really would love fix-a-bug PRs or something ;-D

Edit: Fix typos

@piraces
Copy link
Contributor Author

piraces commented Oct 15, 2023

I just have made the changes.

What I wanted to say: I would rather not promote add-a-font PRs.
I really would love fix-a-bug PRs or something ;-D

I completely understand your point, if I have more time I will work on bugs or something related better than new fonts 😄

@adrianvalenz
Copy link

This looks almost good! :-)

Adding a new font is of course always also kind of 'political'. Is the font interesting enough? Is there demand? Etc. That is of course hard for newly created fonts.

Can I just comment to support this PR...0xProto is an amazing font to work with.

@Finii
Copy link
Collaborator

Finii commented Oct 16, 2023

I mark this as ready now (i.e. I will update the font just on release, if need be).
Thank you for the work 👍

Ah, I will quickly add a commit that unifies the readme style.

@Finii Finii added the Ready ⛱ Ready to merge but waiting to be merged near a release label Oct 16, 2023
@piraces
Copy link
Contributor Author

piraces commented Oct 16, 2023

Thank you for all @Finii !! 👍

@ffainy
Copy link

ffainy commented Nov 10, 2023

0xProto is my favorite code font and I'm glad it's joining nerd font family.
Thanks to all of you for your efforts 👍

@Finii Finii merged commit 7b8b6ce into ryanoasis:master Nov 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❲Aa❳ new font Ready ⛱ Ready to merge but waiting to be merged near a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce 0xProto font
4 participants