Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JetBransMono != ligature #964

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Fix JetBransMono != ligature #964

merged 2 commits into from
Oct 12, 2022

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Oct 12, 2022

[why]
In JetBrainsMono v2.242 the exclam-equal ligature is broken. It has been fixed in v3.000.

[how]
The JetBrains Mono v3 has not been released yet. So we just transplant the one broken glyph from v3.000 into our v2.242.

[note]
JetBrains/JetBrainsMono#494

Fixes: #963

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

[why]
In JetBrainsMono v2.242 the exclam-equal ligature is broken.
It has been fixed in v3.000.

[how]
The JetBrains Mono v3 has not been released yet. So we just transplant
the one broken glyph from v3.000 into our v2.242.

[note]
JetBrains/JetBrainsMono#494

Fixes: #963

Signed-off-by: Fini Jastrow <[email protected]>
[why]
We do not want to rebuild all fonts, just the affected ones.
Without a proper release timestamp this is impossible (i.e. harder) to
do via CI, so do it manually 😬

[how]
./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/ExtraLight
./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/Light

Hmm, the patched fonts got slightly smaller. These font file sizes are a
mystery for me.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii merged commit de06ddf into master Oct 12, 2022
@Finii Finii deleted the bugfix/jetbrainsmono-ligature branch October 12, 2022 06:49
@Finii
Copy link
Collaborator Author

Finii commented Oct 12, 2022

To properly update repo and release candidate...

./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/ExtraLight
./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/Light
./archive-fonts.sh JetBrainsMono

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Not equal (!=)' ligature is broken for all JetBrains Mono Light/ExtraLight weights.
1 participant