Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix licenses in archives #981

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Bugfix licenses in archives #981

merged 3 commits into from
Oct 25, 2022

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Oct 24, 2022

Description

In the release archives (zip files) for some fonts the license file is missing.
This fixes this hopefully for the future.

Requirements / Checklist

What does this Pull Request (PR) do?

Autogenerate and keep up to date the license files in patched-fonts/.
Add OFL.txt to possible (recognized) license files.
Add more license file variations to archives.

How should this be manually tested?

Complete CI release run and look into all zip files, for example

find archives -name "*.zip" -exec echo {} \; -exec unzip -l {} \; | grep 'Archive|li.en|LI.EN|OFL'

This lists archive names and license files; there shall be no archive name without a following license file.

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes: #979

Screenshots (if appropriate or helpful)

[why]
We have 'license' is the archives, but the 'licence' files are missing.
We allow all-caps and all-lowercase, but not camelcase 'License'.
Sometimes we have OFL.txt which is missing.

[how]
Enable both spellings and also camelcase.
Enable OTF text files.

Also fix misunderstanding of regex vs glob ([] vs {}), where the glob
needs a comma and the regex does not.

Add missing LICENSE files for 2 fonts.

Fixes: #979

Reported-by: Jeremy Thorn <moralground>
Signed-off-by: Fini Jastrow <[email protected]>
In fact these would/will be recreated on a gotta-patch-em-all-font-patcher!.sh
run.

Signed-off-by: Fini Jastrow <[email protected]>
[why]
Old (renamed) license files are not cleaned up automatically.
The new files will be put into the patched-fonts dir, but old ones not
removed.

[how]
With commit
  afd7ba1  patch-em-all: Purge destination dirs if possible

the script purges old font files from the patched-fonts directory to get
rid of renamed font files. This has been deliberately limited to ttf and
otf files.

But as all license files are automatically copied over we can also
remove them.

This (finally) remove the possibility to manually put any files in those
directories. This can be good or bad.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii merged commit 98f009d into master Oct 25, 2022
@Finii Finii deleted the bugfix/licenses-in-archives branch October 25, 2022 17:40
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UbuntuMono has no license file
1 participant