Feature-Resume display and download #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ResumeDownloadButton.js
Updated github pages
Missing adding feature to top bar
Added initial resume feature
Resume can now be accessed by the toolbar above and by the button in the greeting page. Fixed the title and subtitle arrangement.
Fixed format
Merge pull request #2 from NMCBU1/master
Resume feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think you don't need to show the resume - just a button with download
resume that download the pdf no need to show it in the portfolio
…On Tue, Apr 23, 2024 at 8:40 PM vercel[bot] ***@***.***> wrote:
*The latest updates on your projects*. Learn more about Vercel for Git ↗︎
<https://vercel.link/github-learn-more>
Name Status Preview Comments Updated (UTC)
*developer-folio* 🔄 Building (Inspect
<https://vercel.com/saadpastas-projects/developer-folio/D2DBDdpCaghjBTpyCju7cJJ2HXdn>
) Visit Preview
<https://vercel.live/open-feedback/developer-folio-git-fork-rebeccali04-master-saadpastas-projects.vercel.app?via=pr-comment-visit-preview-link&passThrough=1> 💬
*Add feedback*
<https://vercel.live/open-feedback/developer-folio-git-fork-rebeccali04-master-saadpastas-projects.vercel.app?via=pr-comment-feedback-link> Apr
23, 2024 3:39pm
—
Reply to this email directly, view it on GitHub
<#698 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AFR2MI4WTITN2XLP6POWKJLY6Z6GFAVCNFSM6AAAAABGVGIYBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSG42TGMJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Peace ✌️
|
|
@saadpasta Just to confirm, you would like clicking on the “See my resume” button to directly start downloading the resume as opposed to allowing to view it and then download it? We added the view functionality so that people can see what they are downloading without going to an external page but it makes sense if we want the resume to be downloaded with just one click from the website viewers. |
Downloads resume after clicking button, Deleted resume container in website
Resume download feature
Changed underlined font of button
for more information, see https://pre-commit.ci
Corrected style on last push
|
Updated the feature to download the resume directly as per comment from @saadpasta |
saadpasta
approved these changes
Apr 28, 2024
Mehranmzn
pushed a commit
to Mehranmzn/mehranmzn.github.io
that referenced
this pull request
Sep 13, 2024
* Create ResumeDownloadButton.js * Updated github pages Updated github pages * Resume feature 1st version Missing adding feature to top bar * Style ran npm run format * Fixed UI to match the webpage Resume can now be accessed by the toolbar above and by the button in the greeting page. Fixed the title and subtitle arrangement. * Fixed format Fixed format * Update README.md with resume instructions * Updated resume feature Downloads resume after clicking button, Deleted resume container in website * Changed underlined font of bottun * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated style to pass lint * Directly Download button --------- Co-authored-by: NMCBU1 <[email protected]> Co-authored-by: NMCBU1 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was made in collaboration with @NMCBU1.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
As per discussion with @saadpasta, we added a resume download capabilities so that potential hiring managers would be able to look at and download the resume with less friction. We changed
greetings.jsso that clicking on the “Download my resume "button would directly download the resume pdf. We made a new container and filesResume.jsandResume.scss. Users can still revert back to using a google drive link by changing the link associated with the “Download my resume” button back to resumeLink.A description of how to customize the resume viewing and downloading feature was also added into the readme file.
Fixes #697
Type of change