Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resume button in nav bar #738

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

Jolomi-Tosanwumi
Copy link
Contributor

@Jolomi-Tosanwumi Jolomi-Tosanwumi commented Oct 13, 2024

Description

Fixed: Resume button in nav bar not redirecting to "DOWNLOAD MY RESUME" button.

Fixes (#737)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-folio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 10:09pm

@Jolomi-Tosanwumi
Copy link
Contributor Author

Jolomi-Tosanwumi commented Oct 14, 2024

[UPDATE]: Added empty div before "DOWNLOAD MY RESUME" button to make the resume nav properly redirected to the the button regardless if the current viewport is before the "DOWNLOAD MY RESUME" button or after it.

@saadpasta
Copy link
Owner

Thanks for contributing @Jolomi-Tosanwumi

@saadpasta saadpasta merged commit 2b94cad into saadpasta:master Oct 18, 2024
3 checks passed
@Jolomi-Tosanwumi
Copy link
Contributor Author

Thank you @saadpasta. Please don't forget to add me as a contributor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants