Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5] Throw InvalidDataException when RRule is invalid #696

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 14, 2024

Backport #692 to 4.5 branch

In master, use Sabre\VObject\InvalidDataException; is already there, because various declarations of things, parameter types, return types etc have been added in master. I had to add the use statement in the backport.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (7201ecf) to head (8b3e5d2).
Report is 8 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #696   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
- Complexity     1931     1932    +1     
=========================================
  Files            71       71           
  Lines          5294     5297    +3     
=========================================
+ Hits           5223     5226    +3     
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis merged commit 72ec4ce into sabre-io:4.5 Oct 14, 2024
11 checks passed
@phil-davis phil-davis deleted the rrule-invalid-4.5 branch October 14, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants