Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added phpstan types to deserializer functions #213

Merged
merged 13 commits into from
Jul 26, 2022
Merged

added phpstan types to deserializer functions #213

merged 13 commits into from
Jul 26, 2022

Conversation

staabm
Copy link
Member

@staabm staabm commented Jul 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #213 (98ee36e) into master (584d601) will not change coverage.
The diff coverage is n/a.

❗ Current head 98ee36e differs from pull request most recent head 9b62a05. Consider uploading reports for the commit 9b62a05 to get more accurate results

@@            Coverage Diff            @@
##             master     #213   +/-   ##
=========================================
  Coverage     96.88%   96.88%           
  Complexity      116      116           
=========================================
  Files            13       13           
  Lines           482      482           
=========================================
  Hits            467      467           
  Misses           15       15           
Impacted Files Coverage Δ
lib/Deserializer/functions.php 89.69% <ø> (ø)
lib/Service.php 98.50% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@staabm staabm marked this pull request as ready for review July 25, 2022 17:00
phpstan-baseline.neon Outdated Show resolved Hide resolved
phpstan-baseline.neon Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

@staabm I made a couple of comments above. See what you think...

@staabm staabm mentioned this pull request Jul 26, 2022
@staabm staabm merged commit 15d4f38 into master Jul 26, 2022
@staabm staabm deleted the staabm-patch-1 branch July 26, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants