Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD build get's recognized as ESM by some bundlers such as esbuild/tsup #1804

Open
segevfiner opened this issue Oct 23, 2023 · 0 comments
Open
Labels

Comments

@segevfiner
Copy link

Please respect maintainers time by filling in these sections. Your issue will likely be closed without this information.

  • Vue Version: 3.3.4
  • Vue Select Version: 4.0.0-beta.6

Describe the bug
The umd build gets recognized as ESM by esbuild/tsup because its file extension is .js and the package.json specifies "type": "module" it should have a .cjs extension to be recognized correctly.

Reproduction Link

Steps To Reproduce

  1. Build a package using vue-select with tsup for node (SSR) in CJS format.

Expected behavior
It builds correctly, instead, due to incorrectly assuming the UMD build is ESM, the module.exports statement will be left in the bundle and will overwrite the real module.exports.

@segevfiner segevfiner added the bug label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant