Code gardening

Installer/Compiler.cs

@@ -13,7 +13,7 @@
 
 namespace Installer;
 
-internal class Compiler
+internal partial class Compiler
 {
  private ZipArchive ProjectArchive { get; }
  private Installation Installation { get; }
@@ -42,9 +42,9 @@ public Compiler(ZipArchive projectArchive, CompilationContext context)
 
  private IEnumerable<string> GetSourceFiles()
  {
- var matches = Regex.Matches(ProjectContent, "<Compile\\s+Include=\"(?<file>.*)\"\\s*/>");
+ var matches = CompileFileRegex().Matches(ProjectContent);
 
- foreach (Match match in matches)
+ foreach (var match in matches.Cast<Match>())
  {
  if (!match.Success)
  continue;
@@ -116,9 +116,9 @@ private IEnumerable<MetadataReference> GetReferences()
  {
  yield return MetadataReference.CreateFromFile(Path.Combine(Installation.Managed, "mscorlib.dll"));
 
- var matches = Regex.Matches(ProjectContent, "<(Project)?Reference\\s+Include=\"(?<assemblyName>.*)\"\\s*/?>");
+ var matches = ProjectReferenceRegex().Matches(ProjectContent);
 
- foreach (Match match in matches)
+ foreach (var match in matches.Cast<Match>())
  {
  if (!match.Success)
  continue;
@@ -166,4 +166,10 @@ public CSharpCompilation Compile(string assemblyName)
 
  return CSharpCompilation.Create(assemblyName, syntaxTrees, references, CompilationOptions);
  }
+
+ [GeneratedRegex("<Compile\\s+Include=\"(?<file>.*)\"\\s*/>")]
+ private static partial Regex CompileFileRegex();
+
+ [GeneratedRegex("<(Project)?Reference\\s+Include=\"(?<assemblyName>.*)\"\\s*/?>")]
+ private static partial Regex ProjectReferenceRegex();
 }

Installer/InstallCommand.cs

@@ -154,7 +154,7 @@ public override async Task<int> ExecuteAsync(CommandContext commandContext, Sett
  }
  }
 
- if (compilation == null && files.Any() && files.All(f => f!.StartsWith(features)))
+ if (compilation == null && files.Length != 0 && files.All(f => f!.StartsWith(features)))
  {
  // Failure, retry by removing faulting features if possible
  AnsiConsole.MarkupLine($"[yellow]Trying to disable faulting feature(s): [red]{GetFaultingFeatures(files)}[/].[/]");
@@ -163,7 +163,7 @@ public override async Task<int> ExecuteAsync(CommandContext commandContext, Sett
 
  (compilation, archive, errors) = await GetCompilationAsync(context);
 
- if (!errors.Any())
+ if (errors.Length == 0)
  AnsiConsole.MarkupLine("[yellow]We found a fallback! But please file an issue here : https:/sailro/EscapeFromTarkov-Trainer/issues [/]");
  }
 
@@ -241,7 +241,7 @@ private static void TryCreateGameDocumentFolder()
  AnsiConsole.MarkupLine($"[grey]>> {error.Id} [[{error.Location.SourceTree?.FilePath.EscapeMarkup()}]]: {error.GetMessage().EscapeMarkup()}.[/]");
 #endif
 
- if (errors.Any())
+ if (errors.Length != 0)
  {
  AnsiConsole.MarkupLine($">> [blue]Try #{context.Try}[/] [yellow]Compilation failed for {context.Branch.EscapeMarkup()} branch.[/]");
  compilation = null;

Installer/Installation.cs

@@ -25,7 +25,7 @@ internal class Installation
  private Installation(string location, Version version)
  {
  if (string.IsNullOrEmpty(location))
- throw new ArgumentException(nameof(location));
+ throw new ArgumentException("empty location");
 
  Location = location;
  Version = version;

Installer/Installer.csproj

@@ -17,6 +17,8 @@
  <RepositoryUrl>https:/sailro/EscapeFromTarkov-Trainer</RepositoryUrl>
  <Version>2.6.0.0</Version>
  <Copyright>Sebastien Lebreton</Copyright>
+ <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+ <NeutralLanguage>en-US</NeutralLanguage>
  </PropertyGroup>
 
  <ItemGroup>

Installer/ParentProcessHelper.cs

@@ -5,8 +5,8 @@
 
 namespace Installer;
 
-[StructLayout(LayoutKind.Sequential)]
-public struct ParentProcessHelper
+[StructLayout(LayoutKind.Sequential), System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006")]
+public partial struct ParentProcessHelper
 {
  // These members must match PROCESS_BASIC_INFORMATION
  internal IntPtr Reserved1;
@@ -16,8 +16,8 @@ public struct ParentProcessHelper
  internal IntPtr UniqueProcessId;
  internal IntPtr InheritedFromUniqueProcessId;
 
- [DllImport("ntdll.dll")]
- private static extern int NtQueryInformationProcess(IntPtr processHandle, int processInformationClass, ref ParentProcessHelper processInformation, int processInformationLength, out int returnLength);
+ [LibraryImport("ntdll.dll")]
+ private static partial int NtQueryInformationProcess(IntPtr processHandle, int processInformationClass, ref ParentProcessHelper processInformation, int processInformationLength, out int returnLength);
 
  public static Process? GetParentProcess()
  {

UI/ColorPicker.cs

@@ -24,7 +24,7 @@ public class ColorPicker : Picker<Color>
  private readonly Texture2D _rightArrow;
  private readonly Texture2D _leftArrow;
 
- const int HsvPickerSize = 120, HuePickerWidth = 16;
+ private const int HsvPickerSize = 120, HuePickerWidth = 16;
 
  public ColorPicker(Color color) : base(color)
  {

UI/Picker.cs

@@ -6,6 +6,7 @@ public abstract class Picker<T>
  public T Value => _value;
  public abstract bool IsSelected { get; protected set; }
 
+ [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE0290")]
  protected Picker(T value)
  {
  _value = value;