Add eslint plugin saleor app (#1579)

saleor · Sep 20, 2024 · e7e47bf · e7e47bf
1 parent ca5b6fd
commit e7e47bf
Show file tree

Hide file tree

Showing 11 changed files with 208 additions and 64 deletions.
diff --git a/apps/avatax/.eslintrc b/apps/avatax/.eslintrc
@@ -8,6 +8,10 @@
  {
  "allowList": ["GITHUB_SHA", "VERCEL_GIT_COMMIT_SHA", "VERCEL_URL", "VERCEL"]
  }
- ]
+ ],
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
  }
 }
diff --git a/apps/cms-v2/.eslintrc.json b/apps/cms-v2/.eslintrc.json
@@ -1,4 +1,10 @@
 {
  "root": true,
- "extends": ["saleor"]
+ "extends": ["saleor"],
+ "rules": {
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
 }
diff --git a/apps/klaviyo/.eslintrc b/apps/klaviyo/.eslintrc
@@ -2,6 +2,10 @@
  "root": true,
  "extends": ["saleor"],
  "rules": {
- "no-console": "error"
+ "no-console": "error",
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
  }
 }
diff --git a/apps/products-feed/.eslintrc b/apps/products-feed/.eslintrc
@@ -1,4 +1,10 @@
 {
  "root": true,
- "extends": ["saleor"]
+ "extends": ["saleor"],
+ "rules": {
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
 }
diff --git a/apps/search/.eslintrc b/apps/search/.eslintrc
@@ -1,4 +1,10 @@
 {
  "root": true,
- "extends": ["saleor"]
+ "extends": ["saleor"],
+ "rules": {
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
 }
diff --git a/apps/smtp/.eslintrc b/apps/smtp/.eslintrc
@@ -1,4 +1,10 @@
 {
  "root": true,
- "extends": ["saleor"]
+ "extends": ["saleor"],
+ "rules": {
+ "@saleor/saleor-app/logger-leak": "warn"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
 }
diff --git a/packages/eslint-config-saleor/index.js b/packages/eslint-config-saleor/index.js
@@ -1,5 +1,5 @@
 module.exports = {
- extends: ["next", "turbo", "prettier"],
+ extends: ["next", "turbo", "prettier", "plugin:@saleor/saleor-app/recommended"],
  parser: "@typescript-eslint/parser",
  plugins: ["simple-import-sort"],
  rules: {

diff --git a/packages/eslint-config-saleor/package.json b/packages/eslint-config-saleor/package.json
@@ -2,14 +2,15 @@
  "name": "eslint-config-saleor",
  "version": "0.4.10",
  "devDependencies": {
+ "@saleor/eslint-plugin-saleor-app": "0.1.2",
  "@typescript-eslint/parser": "7.15.0",
  "eslint": "../../node_modules/eslint",
  "eslint-config-next": "14.2.4",
  "eslint-config-prettier": "9.1.0",
  "eslint-config-turbo": "1.10.3",
+ "eslint-plugin-import": "2.29.1",
  "eslint-plugin-react": "7.34.3",
  "eslint-plugin-simple-import-sort": "12.1.1",
- "eslint-plugin-import": "2.29.1",
  "next": "14.2.3",
  "typescript": "5.5.4"
  },

diff --git a/packages/logger/.eslintrc b/packages/logger/.eslintrc
@@ -0,0 +1,7 @@
+{
+ "root": true,
+ "extends": ["saleor"],
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
+}
diff --git a/packages/webhook-utils/.eslintrc b/packages/webhook-utils/.eslintrc
@@ -1,4 +1,10 @@
 {
  "root": true,
- "extends": ["saleor"]
+ "extends": ["saleor"],
+ "rules": {
+ "@saleor/saleor-app/logger-leak": "off"
+ },
+ "parserOptions": {
+ "project": "tsconfig.json"
+ }
 }