Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted _resolveAliases to allow for object aliases #65

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

micahgodbolt
Copy link
Contributor

When resolving aliases I added a check to see if alias value was a string, otherwise it uses the value key, mimicking the props data structure.

We want to do this because some sets of aliases need additional meta data that we'll be using to check a11y.

Something like:

aliases:
  foreground:
    value: white
    contrastsTo: background
  background:
    value: black

This also allows for better meta data when documenting all of your aliases.

@kaelig kaelig modified the milestone: v5.0.0 Dec 14, 2016
@kaelig
Copy link
Contributor

kaelig commented Dec 14, 2016

Thanks @micahgodbolt, do you need some help to write some tests around this feature?

@micahgodbolt
Copy link
Contributor Author

I'm going to try to tackle the testing updates on this. Wish me luck!

@kaelig
Copy link
Contributor

kaelig commented Dec 14, 2016

@jina
Copy link

jina commented Dec 15, 2016

bitmoji

@kaelig kaelig merged commit 0bb4e69 into salesforce-ux:master Dec 15, 2016
@kaelig
Copy link
Contributor

kaelig commented Dec 15, 2016

This PR contains a commit that was merged as part of #69 / #66, but you're still on the spot for writing tests for it and mention the change in the release notes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants