test(rollup-plugin): speedup by adding lwc dep to externals (#4534)

salesforce · Sep 9, 2024 · 19b1e44 · 19b1e44
1 parent 294d24b
commit 19b1e44
Show file tree

Hide file tree

Showing 6 changed files with 90 additions and 146 deletions.
diff --git a/packages/@lwc/rollup-plugin/src/__tests__/apiVersion/apiVersion.spec.ts b/packages/@lwc/rollup-plugin/src/__tests__/apiVersion/apiVersion.spec.ts
@@ -19,6 +19,7 @@ describe('API versioning', () => {
  const bundle = await rollup({
  input: path.resolve(__dirname, pathname),
  plugins: [lwc(options)],
+ external: ['lwc'],
  onwarn(warning) {
  warnings.push(warning);
  },

diff --git a/packages/@lwc/rollup-plugin/src/__tests__/compilerConfig/compilerConfig.spec.ts b/packages/@lwc/rollup-plugin/src/__tests__/compilerConfig/compilerConfig.spec.ts
@@ -5,19 +5,36 @@
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
 import path from 'path';
-import { rollup, RollupLog } from 'rollup';
+import { rollup, type RollupLog, type RollupBuild } from 'rollup';
+
+import lwc, { type RollupLwcOptions } from '../../index';
+
+async function runRollup(
+ pathname: string,
+ options: RollupLwcOptions = {},
+ { external = [] as string[] } = {}
+): Promise<{ bundle: RollupBuild; warnings: RollupLog[] }> {
+ const warnings: RollupLog[] = [];
+
+ const bundle = await rollup({
+ input: path.resolve(__dirname, 'fixtures', pathname),
+ plugins: [lwc(options)],
+ external: ['lwc', ...external],
+ onwarn(warning) {
+ warnings.push(warning);
+ },
+ });
 
-import lwc from '../../index';
+ return {
+ bundle,
+ warnings,
+ };
+}
 
 describe('templateConfig', () => {
  it('compile with preserveHtmlComments option', async () => {
- const bundle = await rollup({
- input: path.resolve(__dirname, 'fixtures/test/test.js'),
- plugins: [
- lwc({
- preserveHtmlComments: true,
- }),
- ],
+ const { bundle } = await runRollup('test/test.js', {
+ preserveHtmlComments: true,
  });
 
  const { output } = await bundle.generate({
@@ -28,13 +45,8 @@ describe('templateConfig', () => {
  });
 
  it('should accept disableSyntheticShadowSupport config flag', async () => {
- const bundle = await rollup({
- input: path.resolve(__dirname, 'fixtures/test/test.js'),
- plugins: [
- lwc({
- disableSyntheticShadowSupport: true,
- }),
- ],
+ const { bundle } = await runRollup('test/test.js', {
+ disableSyntheticShadowSupport: true,
  });
 
  const { output } = await bundle.generate({
@@ -47,13 +59,8 @@ describe('templateConfig', () => {
  });
 
  it('should accept enableDynamicComponents config flag', async () => {
- const bundle = await rollup({
- input: path.resolve(__dirname, 'fixtures/dynamicComponent/dynamicComponent.js'),
- plugins: [
- lwc({
- enableDynamicComponents: true,
- }),
- ],
+ const { bundle } = await runRollup('dynamicComponent/dynamicComponent.js', {
+ enableDynamicComponents: true,
  });
 
  const { output } = await bundle.generate({
@@ -64,17 +71,8 @@ describe('templateConfig', () => {
  });
 
  it('should accept experimentalDynamicDirective config flag', async () => {
- const warnings: RollupLog[] = [];
- const bundle = await rollup({
- input: path.resolve(__dirname, 'fixtures/experimentalDynamic/experimentalDynamic.js'),
- plugins: [
- lwc({
- experimentalDynamicDirective: true,
- }),
- ],
- onwarn(warning) {
- warnings.push(warning);
- },
+ const { bundle, warnings } = await runRollup('experimentalDynamic/experimentalDynamic.js', {
+ experimentalDynamicDirective: true,
  });
 
  const { output } = await bundle.generate({
@@ -92,15 +90,15 @@ describe('templateConfig', () => {
 describe('javaScriptConfig', () => {
  it('should accept experimentalDynamicComponent config flag', async () => {
  const CUSTOM_LOADER = '@salesforce/loader';
- const bundle = await rollup({
- input: path.resolve(__dirname, 'fixtures/dynamicImportConfig/dynamicImportConfig.js'),
- plugins: [
- lwc({
-  experimentalDynamicComponent: { loader: CUSTOM_LOADER, strictSpecifier: true },
-  }),
- ],
- external: [CUSTOM_LOADER],
- });
+ const { bundle } = await runRollup(
+ 'dynamicImportConfig/dynamicImportConfig.js',
+ {
+ experimentalDynamicComponent: { loader: CUSTOM_LOADER, strictSpecifier: true },
+ },
+ {
+  external: [CUSTOM_LOADER],
+ }
+ );
 
  const { output } = await bundle.generate({
  format: 'esm',
@@ -116,17 +114,12 @@ describe('lwsConfig', () => {
  return string.replace(/\s/g, '');
  }
 
- const bundle = await rollup({
- input: path.resolve(
- __dirname,
- 'fixtures/lightningWebSecurityTransforms/lightningWebSecurityTransforms.js'
- ),
- plugins: [
- lwc({
- enableLightningWebSecurityTransforms: true,
- }),
- ],
- });
+ const { bundle } = await runRollup(
+ 'lightningWebSecurityTransforms/lightningWebSecurityTransforms.js',
+ {
+ enableLightningWebSecurityTransforms: true,
+ }
+ );
 
  const { output } = await bundle.generate({
  format: 'esm',

diff --git a/...gin/src/__tests__/enableStaticContentOptimization/enableStaticContentOptimization.spec.ts b/...gin/src/__tests__/enableStaticContentOptimization/enableStaticContentOptimization.spec.ts
@@ -17,6 +17,7 @@ describe('enableStaticContentOptimization: ', () => {
  const bundle = await rollup({
  input: path.resolve(__dirname, pathname),
  plugins: [lwc(options)],
+ external: ['lwc'],
  onwarn(warning) {
  warnings.push(warning);
  },

diff --git a/packages/@lwc/rollup-plugin/src/__tests__/integrations/integrations.spec.ts b/packages/@lwc/rollup-plugin/src/__tests__/integrations/integrations.spec.ts
@@ -15,6 +15,7 @@ describe('integration', () => {
  const bundle = await rollup({
  input: path.resolve(__dirname, 'fixtures/typescript/typescript.ts'),
  plugins: [lwc()],
+ external: ['lwc'],
  });
 
  const result = await bundle.generate({