test(ssr-compiler): harmonize fixture format (#4407)

Co-Authored-By: Eugene Kashida [email protected] Co-Authored-By: Dale Bustad [email protected]
salesforce · Jul 25, 2024 · d7147ce · d7147ce
1 parent e5a1ecb
commit d7147ce
Show file tree

Hide file tree

Showing 102 changed files with 9 additions and 6 deletions.
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts b/packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts
@@ -114,8 +114,8 @@ function testFixtures() {
  });
 
  return {
- 'expected.html': result ? formatHTML(result) : undefined,
- 'error.txt': err,
+ 'expected.html': result ? formatHTML(result) : '',
+ 'error.txt': err ?? '',
  };
  }
  );

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-and-class-modify/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-and-class-modify/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-aria-modify/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-aria-modify/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-aria/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-aria/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-boolean-expr/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-boolean-expr/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-boolean/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-boolean/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-aria/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-aria/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-global-html/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-global-html/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-escape/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-escape/error.txt
diff --git a/...ges/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-with-scoped-css/error.txt b/...ges/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-with-scoped-css/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-global-html/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-global-html/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-live-bindings/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-live-bindings/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-modify-uppercase/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-modify-uppercase/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-namespace/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-namespace/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-scoped-id/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-scoped-id/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-static/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-static/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attributes-aria/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/attributes-aria/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-basic/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-basic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-foreach/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-foreach/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-if/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-if/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-slot/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-slot/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-text-preserve-off/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-text-preserve-off/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/comments-text-preserve/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/comments-text-preserve/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/component/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/component/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/computed/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/computed/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-deep/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-deep/error.txt
diff --git a/...wc/engine-server/src/__tests__/fixtures/context-installation-on-non-element/expected.html b/...wc/engine-server/src/__tests__/fixtures/context-installation-on-non-element/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-no-provider/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-no-provider/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-shadowed/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-shadowed/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-simple/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-simple/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/custom-styles-with-newlines/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/custom-styles-with-newlines/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/deeply-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/deeply-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/delegates-focus/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/delegates-focus/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/directive-external/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/directive-external/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-component-no-ctor/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-component-no-ctor/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-components/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-components/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-slots/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/dynamic-slots/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/face-callback/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/face-callback/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/getter-class-list-noop/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/getter-class-list-noop/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/getter-class-list/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/getter-class-list/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/getter-is-connected/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/getter-is-connected/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/if-block/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/if-block/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/if-conditional-slot-content/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/if-conditional-slot-content/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/if-conditional-slot/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/if-conditional-slot/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/if-custom-element-child/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/if-custom-element-child/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/if-element-child/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/if-element-child/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lifecycle-hooks/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lifecycle-hooks/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom-multiple/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom-multiple/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom-scoped-styles/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom-scoped-styles/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/light-dom/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-dom-manual/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-dom-manual/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-dynamic/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-dynamic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-inner-html/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-inner-html/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/method-get-attribute/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/method-get-attribute/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/method-remove-attribute/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/method-remove-attribute/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/method-set-attribute/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/method-set-attribute/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/methods-unsupported/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/methods-unsupported/error.txt
diff --git a/...ages/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-basic/expected.html b/...ages/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-basic/expected.html
diff --git a/...ages/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-child/expected.html b/...ages/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-child/expected.html
diff --git a/...@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-deep-child/expected.html b/...@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-deep-child/expected.html
diff --git a/...es/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-slotted/expected.html b/...es/@lwc/engine-server/src/__tests__/fixtures/no-boundary-protection-slotted/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/overwrite-properties-template/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/overwrite-properties-template/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/overwrite-properties/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/overwrite-properties/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/parent-child-connected-callback/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/parent-child-connected-callback/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/parent-child-read-only-prop/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/parent-child-read-only-prop/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/rehydration/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/rehydration/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/basic/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/basic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/for-each/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/for-each/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/named-slot/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/named-slot/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slotchange/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slotchange/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slots-fallback/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slots-fallback/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slots-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slots-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slots-unknown/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slots-unknown/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slots/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slots/error.txt
diff --git a/...ngine-server/src/__tests__/fixtures/styles-escaping-invalid-multiple-levels/expected.html b/...ngine-server/src/__tests__/fixtures/styles-escaping-invalid-multiple-levels/expected.html
diff --git a/...ne-server/src/__tests__/fixtures/styles-escaping-invalid-trailing-close-tag/expected.html b/...ne-server/src/__tests__/fixtures/styles-escaping-invalid-trailing-close-tag/expected.html
diff --git a/...ine-server/src/__tests__/fixtures/styles-escaping-invalid-trailing-open-tag/expected.html b/...ine-server/src/__tests__/fixtures/styles-escaping-invalid-trailing-open-tag/expected.html
diff --git a/...ine-server/src/__tests__/fixtures/styles-escaping-invalid-unclosed-open-tag/expected.html b/...ine-server/src/__tests__/fixtures/styles-escaping-invalid-unclosed-open-tag/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/styles-escaping-safe/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/styles-escaping-safe/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/styles-escaping-unsafe/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/styles-escaping-unsafe/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/styles-keyframes/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/styles-keyframes/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/styles-shared/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/styles-shared/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/styles/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/styles/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/svgs/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/svgs/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/tag-name/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/tag-name/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation-escape/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation-escape/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/text-static/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/text-static/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/this-dot-host-element/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/this-dot-host-element/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/error.txt
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts b/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts
@@ -90,12 +90,12 @@ function testFixtures() {
  );
  return {
  'expected.html': formatHTML(result),
- 'error.txt': undefined,
+ 'error.txt': '',
  };
- } catch (_err: any) {
+ } catch (err: any) {
  return {
- 'error.txt': _err.message,
- 'expected.html': undefined,
+ 'error.txt': err.message,
+ 'expected.html': '',
  };
  }
  }

diff --git a/scripts/jest/root.config.js b/scripts/jest/root.config.js
@@ -19,6 +19,9 @@ module.exports = {
  '<rootDir>/packages/@lwc/rollup-plugin',
  '<rootDir>/packages/@lwc/shared',
  '<rootDir>/packages/@lwc/signals',
+ // We will enable this for realsies once all the tests are passing, but for now having the env var avoids
+ // running these tests in CI while still allowing for local testing.
+ ...(process.env.TEST_SSR_COMPILER ? ['<rootDir>/packages/@lwc/ssr-compiler'] : []),
  '<rootDir>/packages/@lwc/style-compiler',
  '<rootDir>/packages/@lwc/synthetic-shadow',
  '<rootDir>/packages/@lwc/template-compiler',