Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run hydration tests in production mode #3253

Closed
nolanlawson opened this issue Dec 21, 2022 · 1 comment · Fixed by #4338
Closed

Add option to run hydration tests in production mode #3253

nolanlawson opened this issue Dec 21, 2022 · 1 comment · Fixed by #4338
Labels
BUG P3 tests Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

(Follow-up to #3158)

We should run the hydration tests in prod mode as well. Otherwise we can't cover branching like this (in hydrateCustomElement):

if (process.env.NODE_ENV !== 'production') {
assert.isTrue(vm.state === VMState.created, `${vm} cannot be recycled.`);
}

@git2gus
Copy link

git2gus bot commented Dec 21, 2022

This issue has been linked to a new work item: W-12259370

@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Aug 11, 2023
nolanlawson added a commit that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG P3 tests Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant