fix: use legal format for compiler version comment #4637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Oct 15, 2024
nolanlawson
reviewed
Oct 15, 2024
|
Changed to |
nolanlawson
reviewed
Oct 15, 2024
packages/@lwc/template-compiler/src/__tests__/fixtures/static-content/no-escaping-tags/ast.json
Outdated
Show resolved
Hide resolved
…ler-version-comment
cardoso
commented
Oct 16, 2024
There was a problem hiding this comment.
@nolanlawson karma tests are passing now, but not sure why I had to update these snapshots...
| @@ -4,7 +4,7 @@ import { freezeTemplate, parseFragment, registerTemplate } from "lwc"; | |||
| const $fragment1 = parseFragment`<xmp${3}></xmp>Hello <div>world</div> <div>foo</div></xmp>`; | |||
| const $fragment2 = parseFragment`<iframe${3}>Hello <div>world</div> <div>foo</div></iframe>`; | |||
| const $fragment3 = parseFragment`<noembed${3}>Hello <div>world</div> <div>foo</div></noembed>`; | |||
| const $fragment4 = parseFragment`<noframes${3}><p${3}>It seems your browser does not support frames or is configured to not allow them.</p></noframes>`; | |||
| const $fragment4 = parseFragment`<noframes${3}><p>It seems your browser does not support frames or is configured to not allow them.</p></noframes>`; | |||
Comment on lines
217
to
230
| "type": "Text", | ||
| "raw": "<p>It seems your browser does not support frames or is configured to not allow them.</p>", | ||
| "value": { | ||
| "type": "Literal", | ||
| "value": "<p>It seems your browser does not support frames or is configured to not allow them.</p>" | ||
| }, | ||
| "attributes": [], | ||
| "properties": [], | ||
| "directives": [], | ||
| "listeners": [], | ||
| "children": [ | ||
| { | ||
| "type": "Text", | ||
| "raw": "It seems your browser does not support frames or is configured to not allow them.", | ||
| "value": { | ||
| "type": "Literal", | ||
| "value": "It seems your browser does not support frames or is configured to not allow them." | ||
| }, | ||
| "location": { | ||
| "startLine": 14, | ||
| "startColumn": 12, | ||
| "endLine": 14, | ||
| "endColumn": 93, | ||
| "start": 316, | ||
| "end": 397 | ||
| } | ||
| } | ||
| ] | ||
| "location": { | ||
| "startLine": 13, | ||
| "startColumn": 15, | ||
| "endLine": 15, | ||
| "endColumn": 5, | ||
| "start": 304, | ||
| "end": 406 | ||
| } |
|
I thought about this some more, and I'm not sure this is the right approach anymore:
|
|
Thanks @nolanlawson . I'll close this one for now and think about an alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Closes #4621
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
In dev mode the compiler version comment emitted will be in the format
/*@preserve LWC compiler vX.X.X*/instead of/*LWC compiler vX.X.X*/. Tools like Vite and Esbuild will now preserve this comment in dev mode by default (configurable in the tools themselves).GUS work item