Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic class with empty string results in hydration mismatch #4661

Open
nolanlawson opened this issue Oct 18, 2024 · 0 comments
Open

Dynamic class with empty string results in hydration mismatch #4661

nolanlawson opened this issue Oct 18, 2024 · 0 comments
Labels
bug SSR Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

nolanlawson commented Oct 18, 2024 •
edited
Loading

Using class={classes} where classes is the empty string ('') results in a hydration mismatch after SSR+hydration.

Repro (13e4359):

Result:

        Expected <p>...</p> to be <p>...</p>

We should probably check for the empty string in style as well.
@nolanlawson nolanlawson added SSR bug Up for grabs Issues that are relatively small, self-contained, and ready for implementation labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug SSR Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson