chore(tachometer): fix remote branches #4510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
At some point our Tachometer scripts got messed up, and when it tries to compare against a remote branch (e.g.
master
) it fails because NX thinks that the@lwc/perf-benchmarks-components
project doesn't exist.This seems to be something subtle with how we were copying directory around (maybe NX is using symlinks under the hood or something)? Doing
yarn install
after copying these files, and copying only the necessary source files, seems to fix the issue.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?