fix(ssr-compiler): define setters for reflected attributes #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
approved these changes
Oct 7, 2024
nolanlawson
reviewed
Oct 14, 2024
| ) | ||
| ), | ||
| ]) | ||
| ) |
There was a problem hiding this comment.
This would benefit from a code comment showing an example output. ASTs are hard to read...
nolanlawson
reviewed
Oct 14, 2024
| setAttribute(attrName: string, value: string | null): void { | ||
| this.__attrs[attrName] = String(value); | ||
| setAttribute(attrName: string, attrValue: unknown): void { | ||
| this.#setAttribute(attrName, String(attrValue)); |
There was a problem hiding this comment.
It's a bit confusing to have two methods named setAttribute and #setAttribute. Maybe #setAttributeWithoutTypeCoercion or something?
nolanlawson
reviewed
Oct 14, 2024
| } | ||
|
|
||
| hasAttribute(attrName: unknown): boolean { | ||
| return typeof attrName === 'string' && typeof this.__attrs[attrName] === 'string'; |
There was a problem hiding this comment.
The fact that we have to check for strings here because we don't ensure that the values in this.__attrs is only a string type is odd to me. We should probably do the validation/coercion on the way in.
There was a problem hiding this comment.
OK, so the reason for this is that we can't call delete because that would delete the getter/setter which is required for prop/attr reflection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define setters for reflected attributes. Needed to add a private
#setAttribute()method that can setnullwithout turning it into a string so thatremoveAttribute()works as expected.Also
for-ofwas also changed tofor-ininrenderAttrsso that we can iterate over non-string (accessor) enumerable entries.This implementation is now more correct than
engine-serveras it seems the latter may not be handingsetAttribute(null)correctly for standard reflected attributes: