Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve htsget table contents formatting when displayed on GitHub [trivial] #374

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

jmarshall
Copy link
Member

@jmarshall jmarshall commented Jan 24, 2019

I finally figured out how to get markdown nested inside an HTML <table> into a common subset of kramdown and GitHub-flavoured markdown, so that the italics and code etc appear as such (rather than as raw markup) in the rest of the tables when viewing htsget.md within the GitHub repository web view.

@mlin: This has no text changes (and I've verified that it makes no difference to how htsget.html is displayed), so IMHO as editor you should feel free to check it over and merge this without conversation or delay.

It turns out that markdown within HTML <table>...<td> elements does
get formatted if it is set off from the preceding HTML tags with a
blank line.
@mlin mlin merged commit 6052df0 into samtools:master Jan 28, 2019
@jmarshall
Copy link
Member Author

jmarshall commented Jan 28, 2019

Thanks. Out of interest, which merge button did you use (“Squash and merge”?) and did you edit the first line of the commit message yourself or was that partially modified by the GitHub UI? I'm curious how much of the change in the message from the original commit may be related to isaacs/github#1368 (Further testing via PRs in my test repository show that the change in the commit message text was all committer and no UI.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants