-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'includes' instead of 'contains'? #379
Comments
@danwenzel I like the suggestion! If we do this, we should deprecate |
|
@mum-never-proud - I am referring to |
I think we should deprecate |
JS convention seems to have moved toward using the method name
includes
instead ofcontains
. For enumerables, Ember is deprecatingcontains
, andincludes
is pretty much the only available method on JS strings.Shouldn't
ember-cli-page-object
follow this same convention, and useincludes
here instead ofcontains
? http://ember-cli-page-object.js.org/docs/v1.13.x/api/containsThe text was updated successfully, but these errors were encountered: