migrate to pnpm #579
Merged
migrate to pnpm #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
force-pushed
the
v2-addon-fixups
branch
3 times, most recently
from
2a4f285
to
502e6f1
Compare
Merged
in order to avoid ember-source `peerDependency` being hoisted to the root node_modules, which causes unreliable imports in embroider. see: embroider-build/embroider#1169 (comment) Also: - [Breaking] Drop Node@12 support due to `pnpm` requires it - Use slightly dated [email protected], since in the later version there are issues with `--frozen-lockfile` installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After migrating to v2 addon(#576), peerDependencies installation issues have arised with npm. Shortly:
@ember/test-helperspeerDependency of the addon,ember-source@latestis hoisted into the rootnode_modulesdependencySatisfies(of the@embroider/macrosassumes that tests run against theember-source@latest, even though in thetest-appwe have a different ember-source issues, which leads to further runtime errors.The issue is better explained here embroider-build/embroider#1169 (comment).
As far as I can see the only possible workaround for npm could be to set
auto-install-peerstofalsein the.npmrc. However, it still feels like a workaround, and I haven't checked if it really works. So I'm going to switch to pnpm for now cause it doesn't have such an issue.For the record, I'd be happy to come back to npm when the issue would be solved there.
Also:
pnpmrequires v14 or higher--frozen-lockfileinstallations