Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new exception signal for ALL exceptions raised anywhere in application #2724

Merged
merged 4 commits into from
Jul 9, 2023

Conversation

ahopkins
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 70.000% and project coverage change: +0.085 🎉

Comparison is base (11a0b15) 88.884% compared to head (8400f78) 88.969%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2724       +/-   ##
=============================================
+ Coverage   88.884%   88.969%   +0.085%     
=============================================
  Files           92        92               
  Lines         6981      6990        +9     
  Branches      1191      1193        +2     
=============================================
+ Hits          6205      6219       +14     
+ Misses         531       527        -4     
+ Partials       245       244        -1     
Impacted Files Coverage Δ
sanic/app.py 90.169% <ø> (+0.677%) ⬆️
sanic/signals.py 91.216% <57.142%> (-1.692%) ⬇️
sanic/handlers/error.py 97.468% <100.000%> (+0.065%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins marked this pull request as ready for review July 9, 2023 06:57
@ahopkins ahopkins requested a review from a team as a code owner July 9, 2023 06:57
@ahopkins ahopkins merged commit 976da69 into main Jul 9, 2023
32 checks passed
@ahopkins ahopkins deleted the exception-signal branch July 9, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant