Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in getting current request through classmethod when served through a different ASGI server #2760

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Thirumalai
Copy link
Contributor

fixes #2759

@Thirumalai Thirumalai requested a review from a team as a code owner June 9, 2023 17:03
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.001 🎉

Comparison is base (af67801) 88.938% compared to head (59b164f) 88.940%.

❗ Current head 59b164f differs from pull request most recent head 77e626f. Consider uploading reports for the commit 77e626f to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2760       +/-   ##
=============================================
+ Coverage   88.938%   88.940%   +0.001%     
=============================================
  Files           92        92               
  Lines         6952      6953        +1     
  Branches      1185      1185               
=============================================
+ Hits          6183      6184        +1     
  Misses         527       527               
  Partials       242       242               
Impacted Files Coverage Δ
sanic/asgi.py 91.729% <100.000%> (+0.062%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 50117d1 into sanic-org:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get current request through class method while serving the app through other ASGI servers
2 participants