-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to rebuild for electron 28+ (v8 12+) #101
Comments
Done, I just created PR #102 that should fix this. |
While this get's merged and released by @santigimeno you can use my branch by doing
|
Huh, nan 2.19.0 does not fix this issue for Electon 28 builds. I still get:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
V8 v12 brings some breaking changes to the ObjectTemplate::SetAccessor signature. NAN is working on a fix: nodejs/nan#966.
As soon as the fixing NAN version is released I will open a PR. Just wanted to have this tracked.
Thanks!
The text was updated successfully, but these errors were encountered: