Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions and warnings #4420

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Fix exceptions and warnings #4420

merged 4 commits into from
Oct 14, 2024

Conversation

IvanIvanoff
Copy link
Member

  • Fix cryptocompare assets endpoint in case of asset without slug
  • Remove unused default parameter
  • Properly handle price validator timeouts with catch
  • Reintroduce sentiment_volume_consumed_4chan as a name of a metric

Changes

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff merged commit 1c71228 into master Oct 14, 2024
1 of 2 checks passed
@IvanIvanoff IvanIvanoff deleted the fix-exceptions branch October 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant