Fix lints

internal/api/core.go

@@ -203,7 +203,7 @@ func (p *v1Provider) FindDomainFromRequest(w http.ResponseWriter, r *http.Reques
  var domain db.Domain
  err := p.DB.SelectOne(&domain, `SELECT * FROM domains WHERE uuid = $1`, domainUUID)
  switch {
- case err == sql.ErrNoRows:
+ case errors.Is(err, sql.ErrNoRows):
  http.Error(w, "no such domain (if it was just created, try to POST /domains/discover)", http.StatusNotFound)
  return nil
  case respondwith.ErrorText(w, err):
@@ -241,7 +241,7 @@ func (p *v1Provider) FindProjectFromRequestIfExists(w http.ResponseWriter, r *ht
  project = &db.Project{}
  err := p.DB.SelectOne(project, `SELECT * FROM projects WHERE uuid = $1`, projectUUID)
  switch {
- case err == sql.ErrNoRows:
+ case errors.Is(err, sql.ErrNoRows):
  return nil, true
  case err == nil && domain.ID != project.DomainID:
  http.Error(w, "no such project", http.StatusNotFound)

internal/api/projects.go

@@ -259,6 +259,7 @@ func (p *v1Provider) putOrSimulatePutProjectQuotas(w http.ResponseWriter, r *htt
  //validate inputs (within the DB transaction, to ensure that we do not apply
  //inconsistent values later)
  err := updater.ValidateInput(serviceQuotas, dbi)
+ //nolint:errorlint // not applicable
  if _, ok := err.(MissingProjectReportError); ok {
  //MissingProjectReportError indicates that the project is new and initial
  //scraping is not yet done -> ask the user to wait until that's done, with

internal/api/rates.go

@@ -175,6 +175,7 @@ func (p *v1Provider) putOrSimulatePutProjectRates(w http.ResponseWriter, r *http
  //validate inputs (within the DB transaction, to ensure that we do not apply
  //inconsistent values later)
  err := updater.ValidateInput(parseTarget.Project.Services, dbi)
+ //nolint:errorlint // not applicable
  if _, ok := err.(MissingProjectReportError); ok {
  //MissingProjectReportError indicates that the project is new and initial
  //scraping is not yet done -> ask the user to wait until that's done, with

internal/collector/ratescrape.go

@@ -21,6 +21,7 @@ package collector
 
 import (
  "database/sql"
+ "errors"
  "fmt"
  "math/big"
  "time"
@@ -83,7 +84,7 @@ func (c *Collector) ScrapeRates(serviceType string) {
  Scan(&serviceID, &serviceRatesScrapedAt, &serviceRatesScrapeState, &project.Name, &project.UUID, &project.ParentUUID, &project.Domain.Name, &project.Domain.UUID)
  if err != nil {
  //ErrNoRows is okay; it just means that nothing needs scraping right now
- if err != sql.ErrNoRows {
+ if !errors.Is(err, sql.ErrNoRows) {
  c.LogError("cannot select next project for which to scrape %s rate data: %s", serviceType, err.Error())
  }
  if c.Once {

internal/collector/scrape.go

@@ -22,6 +22,7 @@ package collector
 import (
  "database/sql"
  "encoding/json"
+ "errors"
  "fmt"
  "time"
 
@@ -85,7 +86,7 @@ func (c *Collector) Scrape(serviceType string) {
  dbDomain, dbProject, srv, err := c.selectProjectForResourceScrape(serviceType, scrapeStartedAt)
  if err != nil {
  //ErrNoRows is okay; it just means that nothing needs scraping right now
- if err != sql.ErrNoRows {
+ if !errors.Is(err, sql.ErrNoRows) {
  c.LogError("cannot select next project for which to scrape %s resource data: %s", serviceType, err.Error())
  }
  if c.Once {

internal/plugins/neutron.go

@@ -160,6 +160,7 @@ func (p *neutronPlugin) Init(provider *gophercloud.ProviderClient, eo gopherclou
  continue
  }
  _, err := extensions.Get(p.NeutronV2, resource.Extension).Extract()
+ //nolint:errorlint // not applicable
  switch err.(type) {
  case gophercloud.ErrDefault404:
  p.hasExtension[resource.Extension] = false
@@ -173,6 +174,7 @@ func (p *neutronPlugin) Init(provider *gophercloud.ProviderClient, eo gopherclou
 
  // Octavia supported?
  p.OctaviaV2, err = openstack.NewLoadBalancerV2(provider, eo)
+ //nolint:errorlint // not applicable
  switch err.(type) {
  case *gophercloud.ErrEndpointNotFound:
  p.hasOctavia = false

internal/plugins/nova.go

@@ -714,6 +714,7 @@ func (p *novaPlugin) findOSTypeForImage(imageID string) (string, error) {
  err := images.Get(p.GlanceV2, imageID).ExtractInto(&result)
  if err != nil {
  //report a dummy value if image has been deleted...
+ //nolint:errorlint // not applicable
  if _, ok := err.(gophercloud.ErrDefault404); ok {
  return "image-deleted", nil
  }

main.go

@@ -313,6 +313,7 @@ func findProjectForTesting(cluster *core.Cluster, projectUUID string) (core.Keys
 func dumpGeneratedPrometheusMetrics() {
  metricFamilies, err := prometheus.DefaultGatherer.Gather()
  if err != nil {
+ //nolint:errorlint // not applicable
  if merr, ok := err.(prometheus.MultiError); ok {
  for _, err := range merr {
  logg.Error("error while gathering Prometheus metrics: " + err.Error())