add support for rates in plugins/liquid, add liquid-cronus #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
force-pushed
the
liquid-rates
branch
from
54528d7
to
065e67c
Compare
We need this to construct a ServiceUsageRequest in the LIQUID bridge.
majewsky
force-pushed
the
liquid-rates
branch
from
065e67c
to
07cfa68
Compare
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
VoigtS
approved these changes
Sep 27, 2024
| "github.com/gophercloud/gophercloud/v2" | ||
| ) | ||
|
|
||
| // Client is a gophercloud.ServiceClient for the Cronus v1 API. |
There was a problem hiding this comment.
Shouldn't this really go into https:/sapcc/gophercloud-sapcc/ ?
There was a problem hiding this comment.
This only covers a tiny speck of API that only Limes is allowed to use, so there is no benefit to having it in a shared library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For once, we have a new liquid that is an absolutely straight port of the old QuotaPlugin. No interesting changes at all.
I have tested this in QA with
limes test-get-rates; it yields the same results as the old QuotaPlugin.