Add Duration Extension API #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoigtS
requested review from
majewsky,
SuperSandro2000 and
Nuckal777
as code owners
majewsky
requested changes
Oct 8, 2024
replace it with a string compare
majewsky
requested changes
Oct 8, 2024
Change provided duration check to a slice contain instead of checking their string representations. Co-authored-by: Stefan Majewsky <[email protected]>
majewsky
approved these changes
Oct 9, 2024
replace date with the proper word duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an API to extend the duration of a commitment to a valid one provided in its configuration.
This is implemented as a draft, because I'm unsure wheter to create a new commitment or overwrite the current one and add a new DB column with an "Extended_at" field. As an alternative I simply updated the commitment. I would like to hear your oppinion and will implement as desired.
Another note: Before this goes live, the PR requests a change on the vendor file, which would have to be updated first.TODO: