Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update babel and eslint to support es2017 #340

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

PaperStrike
Copy link
Contributor

Resolve MichaelDeBoey#13 (comment)

  • Switch to use babel-preset-env, since babel-preset-es2015 has been deprecated and the former supports es2017 and more configurations
  • Exclude transform-regenerator in babel config since transform-regenerator requires a runtime polyfill and isn't actually needed if we don't use Generator.prototype.return()
  • Update eslint target ecma version to 2017

@ljharb
Copy link
Collaborator

ljharb commented Nov 7, 2021

hmm, it's very strange - you have the "allow edits" box checked, and this PR's fork is your own, but for some reason I can't force push to it.

If you could squash the second one into the first one, that'd be great.

* switch to use `babel-preset-env`, since `babel-preset-es2015` has been deprecated and the former supports es2017 and more configurations
* exclude `transform-regenerator` in babel config since `transform-regenerator` requires a runtime polyfill and isn't actually needed if we don't use `Generator.prototype.return()`
* update eslint target ecma version to 2017
@PaperStrike
Copy link
Contributor Author

PaperStrike commented Nov 7, 2021

squashed! 😀

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #340 (6b4b5a0) into master (bc91e07) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          181       181           
=========================================
  Hits           181       181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc91e07...6b4b5a0. Read the comment docs.

@ljharb ljharb merged commit 6b4b5a0 into sarbbottam:master Nov 7, 2021
@PaperStrike PaperStrike deleted the syntax-2017 branch November 7, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants