Remove __PYVENV_LAUNCHER__ from the environment for child processes. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For framework builds of Python on macOS, if __PYVENV_LAUNCHER__ exists, it's used as the value of sys.executable, and thus is used as the base for a raft of values, including the system directories in sys.path. (See: site.py in Python source) Additionally, python sets this in the environment for subprocesses, as a way to get around some technical issues with launching scripts that use the GUI. (See: Mac/Tools/pythonw.c in Python source) Thus, when vex exec's <virtualenv>/bin/python, the python launched thinks it's actually vex's python, at /opt/local/bin/python (or whatever), and so adds the non-virtualenv paths to sys.path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For framework builds of Python on macOS, if PYVENV_LAUNCHER exists,
it's used as the value of sys.executable, and thus is used as the base
for a raft of values, including the system directories in sys.path.
(See: site.py in Python source)
Additionally, python sets this in the environment for subprocesses,
as a way to get around some technical issues with launching scripts
that use the GUI. (See: Mac/Tools/pythonw.c in Python source)
Thus, when vex exec's /bin/python, the python launched
thinks it's actually vex's python, at /opt/local/bin/python
(or whatever), and so adds the non-virtualenv paths to sys.path.