-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse-time deprecation messages are not properly rate limited #2390
Comments
dart-sass/lib/src/import_cache.dart Lines 360 to 379 in ab19f94
@jathak This seems to be a deliberate choice but I'm afraid that this is way too noisy for large framework like bootstrap. |
import
deprecation messages
I agree that we should make sure this case uses a repetition-limiting logger. Probably from the CLI, we should manually construct a shared logger—or if we're running in watch mode, a separate shared logger for each batch of events. |
In fact, we have the very same issue in both CLI and API due to the
|
See #2390. This is definitely not the correct long-term solution—we only want to limit repetition in the context of a single batch of compilations, and this doesn't always respect `--verbose`—but it's way better to display too few deprecations than too many.
These are not intended to reflect the correct behavior, but rather the fact that we need to limit the amount of repetition univerally until we have time to find a proper solution to the underlying bug.
These are not intended to reflect the correct behavior, but rather the fact that we need to limit the amount of repetition univerally until we have time to find a proper solution to the underlying bug.
See #2390. This is definitely not the correct long-term solution—we only want to limit repetition in the context of a single batch of compilations, and this doesn't always respect `--verbose`—but it's way better to display too few deprecations than too many.
import
deprecation messages
After consulting with @jathak, the current plan here is to move away from emitting any deprecation warnings at parse time at all. Instead, the parser will accumulate a list of deprecations and attach it to a hidden field in the As a side effect of this, we can (Dart-level) deprecate the |
When compiling latest bootstrap, the same
@import
deprecation is printed 87 times, where it should only be printed 5 times and then get summarized.The text was updated successfully, but these errors were encountered: