-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation and length issues for appended variable-length arglist #1171
Comments
Spec added sass/sass-spec#364 |
@davidkpiano is this part of SassDash? |
@xzyfer Yep, |
Ok cool, prioritizing this to 3.2.3. |
First issue is covered by the PR. Maybe we should create a new issue for the second, since it is related to how we handle lists. IMO the second sample can probably be shortened down to: foo {
test-01: inspect(( (1, 2), (3, 4) ));
} ruby sass: foo {
test-01: (1, 2), (3, 4); } libsass: foo {
test-01: 1, 2, 3, 4; } Seems like we join/flatten lists too often ... |
@mgreter Sure, want me to make a new issue with the second example? I feel like it might be an issue with arglists from variable-length arguments, rather than just lists (correct me if I'm wrong), hence the specific example. |
If you can confirm the first one is gone, sure! Close this one then and create a separate issue for the list append bug (which is caused by the sample I posted above, I'm very sure about that). Ruby sass appends |
@mgreter Other way around. It seems that appending 3 to the arglist (1, 2) results in |
This fix was a false positive due to sass/sass-spec#380. The spec still fails. |
😭 |
We're bummed as well. I've patched the test runner so there shouldn't be
|
Compilation runs forever with the below code:
Also, potentially related - an appended variable-length arglist should have an accurate length given by
length()
The text was updated successfully, but these errors were encountered: