Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should throw error we performing binary operations on strings #1451

Closed
xzyfer opened this issue Aug 17, 2015 · 5 comments
Closed

Should throw error we performing binary operations on strings #1451

xzyfer opened this issue Aug 17, 2015 · 5 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Aug 17, 2015

@if "foo" > 0 {}

Ruby Sass

Error: Undefined operation: ""foo" gt 0".
        on line 56 of test.scss

Libsass 3.2.5

Error: may only compare numbers
        on line 56 of test.scss
>> @if "foo" > 0 {}

Libsass master

Segfault
@mgreter
Copy link
Contributor

mgreter commented Aug 23, 2015

Cannot reproduce on current master with mingw and perl-libsass!?

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 24, 2015

I can confirm this issue exists in 0ae11a4 on OSX with clang.

$ clang -v
Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin13.4.0
Thread model: posix

@mgreter
Copy link
Contributor

mgreter commented Aug 24, 2015

Maybe related to #1462 ??

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 24, 2015

Possible. I've left feedback on #1462.

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 24, 2015

I can confirm after applying #1462 locally the segfault is solved. The following is now produced.

Error: may only compare numbers
        on line 29 of test.scss
>> @if "foo" > 0 {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants