Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments between binary operands prevents evalutaion #1765

Closed
xzyfer opened this issue Nov 28, 2015 · 1 comment · Fixed by #1844
Closed

Comments between binary operands prevents evalutaion #1765

xzyfer opened this issue Nov 28, 2015 · 1 comment · Fixed by #1844
Assignees
@mgreter
Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written
Milestone
3.3.3

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Nov 28, 2015

Originally reported in sass/node-sass#1242

foo {
  bar: 20px /* height */ + 2*5px /* padding */ + 2*1px /*border*/;
}

Ruby Sass

foo {
  bar: 32px; }

LibSass

foo {
  bar: 20px 10px 2px; }

Spec added sass/sass-spec#628
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Nov 28, 2015
@xzyfer
Add specs for issue 1765
2a24ac0 
This PR add specs for sass/libsass#1765
@xzyfer xzyfer mentioned this issue Nov 28, 2015
Merged
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Nov 28, 2015
@xzyfer
Add specs for issue 1765
73f1060 
This PR add specs for sass/libsass#1765
@xzyfer xzyfer mentioned this issue Nov 28, 2015
Closed
@mgreter mgreter mentioned this issue Jan 9, 2016
Merged
@mgreter mgreter added this to the 3.3.3 milestone Jan 9, 2016
@mgreter mgreter self-assigned this Jan 9, 2016
@mgreter
Copy link
Contributor

mgreter commented Jan 9, 2016

test should probably be extended to also include comments after the operator

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Jan 12, 2016
@xzyfer
Activate specs for issue 1765
0a764df 
This PR activates specs for sass/libsass#1765
@xzyfer xzyfer mentioned this issue Jan 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.3.3
Development

Successfully merging a pull request may close this issue.

Fix expression parsing with comment between factors mgreter/libsass
2 participants
@mgreter @xzyfer